Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update code example to use .uf2 files for Pi Pico #1319

Merged
merged 1 commit into from
Oct 13, 2024

Conversation

kevinschweikert
Copy link
Contributor

It seems like the code snippets reference the wrong file format for the Pi Pico

These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).

SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later

Copy link
Collaborator

@UncleGrumpy UncleGrumpy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. You are absolutely correct! Thank you.

Copy link
Collaborator

@bettio bettio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind to signoff your commit to make CI happy?

git commit --amend --signoff
git push -f ...

Also I would like to ask you to rebase it on top of release-0.6 that is the branch where we are doing maintenance releases.
(maybe git cherry-pick can be easier than rebasing the whole thing)

Signed-off-by: Kevin Schweikert <[email protected]>
@kevinschweikert
Copy link
Contributor Author

Should be good now

@bettio bettio merged commit 74775d4 into atomvm:release-0.6 Oct 13, 2024
91 of 96 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants